englefly commented on code in PR #11812:
URL: https://github.com/apache/doris/pull/11812#discussion_r950133009


##########
fe/fe-core/src/test/java/org/apache/doris/nereids/util/AnalyzeSubQueryTest.java:
##########
@@ -135,7 +135,7 @@ public void testCaseMixed() {
                             )
                         )
                         .when(FieldChecker.check("joinType", 
JoinType.INNER_JOIN))
-                        .when(FieldChecker.check("condition",
+                        .when(FieldChecker.check("otherJoinCondition",

Review Comment:
   FindHashConditionForJoin Rule is not applied at analyze phase. Before 
FindHashConditionForJoin, all conditions are in otherJoinCondition.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to