englefly commented on code in PR #11812:
URL: https://github.com/apache/doris/pull/11812#discussion_r950126685
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/logical/MultiJoin.java:
##########
@@ -51,11 +54,27 @@ public class MultiJoin extends PlanVisitor<Void, Void> {
* A B
*/
public final List<Plan> joinInputs = new ArrayList<>();
- public final List<Expression> conjuncts = new ArrayList<>();
+ public final List<Expression> conjunctsForAllHashJoins = new ArrayList<>();
+ private List<Expression> conjunctsKeepInFilter = new ArrayList<>();
Review Comment:
it cannot be final. After recursively invoking
reorderJoinsAccordingToConditions(), we need to set it a new value.
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/logical/MultiJoin.java:
##########
@@ -51,11 +54,27 @@ public class MultiJoin extends PlanVisitor<Void, Void> {
* A B
*/
public final List<Plan> joinInputs = new ArrayList<>();
- public final List<Expression> conjuncts = new ArrayList<>();
+ public final List<Expression> conjunctsForAllHashJoins = new ArrayList<>();
+ private List<Expression> conjunctsKeepInFilter = new ArrayList<>();
Review Comment:
it cannot be final. After recursively invoking
`reorderJoinsAccordingToConditions()`, we need to set it a new value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
