[GitHub] [doris] englefly commented on a diff in pull request #11812: [feature](Nereids) support non-equal predicates in Join

[GitBox]

englefly commented on code in PR #11812:
URL: https://github.com/apache/doris/pull/11812#discussion_r949935534


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/algebra/Join.java:
##########
@@ -28,5 +29,9 @@
 public interface Join {
     JoinType getJoinType();
 
-    Optional<Expression> getCondition();
+    List<Expression> getHashJoinPredicates();
+
+    Optional<Expression> getOtherJoinCondition();
+
+    Optional<Expression> getOnClauseCondition();

Review Comment:
   if we name functions like this, how to name conditions from "where clause" ?
   ```
   |----on clause condition: OnClauseCondition
                |----- for hash join : hashJoinCondition
                |------not for hash join: otherJoinCondition
   |----where clause condition: WhereClauseCondition
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org