englefly commented on code in PR #11812:
URL: https://github.com/apache/doris/pull/11812#discussion_r949758787
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/logical/MultiJoin.java:
##########
@@ -185,7 +219,11 @@ public Void visitLogicalJoin(LogicalJoin<Plan, Plan> join,
Void context) {
join.left().accept(this, context);
join.right().accept(this, context);
- join.getCondition().ifPresent(cond ->
conjuncts.addAll(ExpressionUtils.extractConjunction(cond)));
+ conjunctsForAllHashJoins.addAll(join.getHashJoinPredicates());
+ if (join.getOtherJoinCondition().isPresent()) {
+
conjunctsForAllHashJoins.addAll(ExpressionUtils.extractConjunction(join.getOtherJoinCondition().get()));
Review Comment:
before apply FindHashConditionForJoin rule, all the conditions are put into
otherJoinCondition. FindHashConditionForJoin rule will extract hash join
predicates from otherJoinCondition.
MultiJoin applied before FindHashConditionForJoin rule.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
