jackwener commented on code in PR #11209:
URL: https://github.com/apache/doris/pull/11209#discussion_r933961297
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##########
@@ -532,13 +534,23 @@ public List<Expression>
visitNamedExpressionSeq(NamedExpressionSeqContext namedC
* @return List of OrderKey
*/
@Override
- public List<OrderKey> visitQueryOrganization(QueryOrganizationContext ctx)
{
+ public QueryOrganization visitQueryOrganization(QueryOrganizationContext
ctx) {
return ParserUtils.withOrigin(ctx, () -> {
+ List<OrderKey> orderKeys;
if (ctx.sortClause().ORDER() != null) {
- return visit(ctx.sortClause().sortItem(), OrderKey.class);
+ orderKeys = visit(ctx.sortClause().sortItem(), OrderKey.class);
} else {
- return ImmutableList.of();
+ orderKeys = ImmutableList.of();
}
+ long limit = Long.MAX_VALUE;
+ long offset = 0;
+ if (ctx.limitClause().LIMIT() != null) {
+ limit = Long.parseLong(ctx.limitClause().limit.getText());
+ if (ctx.limitClause().OFFSET() != null ||
ctx.limitClause().COMMA() != null) {
+ offset =
Long.parseLong(ctx.limitClause().offset.getText());
+ }
+ }
+ return new QueryOrganization(orderKeys, limit, offset);
Review Comment:
I also think so. We shouldn't add QueryOrganization, it's redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
