englefly commented on code in PR #11209:
URL: https://github.com/apache/doris/pull/11209#discussion_r932809540
##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4:
##########
@@ -119,6 +119,12 @@ sortItem
: expression ordering = (ASC | DESC)?
;
+limitClause
+ : (LIMIT limit=INTEGER_VALUE)?
+ | (LIMIT limit=INTEGER_VALUE OFFSET offset=INTEGER_VALUE)?
+ | (LIMIT offset=INTEGER_VALUE COMMA limit=INTEGER_VALUE)?
+ ;
Review Comment:
It does not save null-checking efforts, if we make sortClause and
LimitClause optional. At least we need to check null for sortClause and
limitClause.
That part of code was updated now. We only check present of limit and
offset, not LIMIT and OFFSET.
```
Token token = ctx.limitClause().limit;
long limit = (token == null) ? Long.MAX_VALUE :
Long.parseLong(token.getText());
token = ctx.limitClause().offset;
long offset = (token == null) ? 0 :
Long.parseLong(token.getText());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
