xiaokang commented on code in PR #10322: URL: https://github.com/apache/doris/pull/10322#discussion_r928252070
########## be/src/vec/data_types/data_type_json.h: ########## @@ -0,0 +1,62 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <ostream> + +#include "vec/columns/column_json.h" +#include "vec/data_types/data_type.h" + +namespace doris::vectorized { +class DataTypeJson final : public IDataType { +public: + using ColumnType = ColumnJson; + using FieldType = JsonField; + static constexpr bool is_parametric = false; + + const char* get_family_name() const override { return "JSON"; } + TypeIndex get_type_id() const override { return TypeIndex::JSON; } + + int64_t get_uncompressed_serialized_bytes(const IColumn& column) const override; + char* serialize(const IColumn& column, char* buf) const override; + const char* deserialize(const char* buf, IColumn* column) const override; + + MutableColumnPtr create_column() const override; + + virtual Field get_default() const override { + LOG(FATAL) << "Method get_default() is not implemented for data type " << get_name(); + // unreachable + return String(); + } + + bool equals(const IDataType& rhs) const override; + + bool get_is_parametric() const override { return false; } + bool have_subtypes() const override { return false; } + bool is_comparable() const override { return false; } + bool can_be_compared_with_collation() const override { return false; } + bool is_value_unambiguously_represented_in_contiguous_memory_region() const override { + return true; + } + bool is_categorial() const override { return true; } Review Comment: return false may be better, since json can contain any value -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
