xiaokang commented on code in PR #10322:
URL: https://github.com/apache/doris/pull/10322#discussion_r928234058


##########
be/src/vec/olap/olap_data_convertor.cpp:
##########
@@ -577,6 +580,77 @@ Status 
OlapBlockDataConvertor::OlapColumnDataConvertorDate::convert_to_olap() {
     }
 }
 
+// class OlapBlockDataConvertor::OlapColumnDataConvertorJson
+void OlapBlockDataConvertor::OlapColumnDataConvertorJson::set_source_column(
+        const ColumnWithTypeAndName& typed_column, size_t row_pos, size_t 
num_rows) {
+    
OlapBlockDataConvertor::OlapColumnDataConvertorBase::set_source_column(typed_column,
 row_pos,
+                                                                           
num_rows);
+    _slice.resize(num_rows);
+}
+
+const void* OlapBlockDataConvertor::OlapColumnDataConvertorJson::get_data() 
const {
+    return _slice.data();
+}
+
+const void* 
OlapBlockDataConvertor::OlapColumnDataConvertorJson::get_data_at(size_t offset) 
const {
+    assert(offset < _num_rows && _num_rows == _slice.size());
+    UInt8 null_flag = 0;
+    if (_nullmap) {
+        null_flag = _nullmap[offset];

Review Comment:
   + _row_pos



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to