yiguolei commented on code in PR #10136:
URL: https://github.com/apache/doris/pull/10136#discussion_r916447721
##########
be/src/olap/tablet_schema.cpp:
##########
@@ -460,27 +503,87 @@ void TabletSchema::init_from_pb(const TabletSchemaPB&
schema) {
_sort_type = schema.sort_type();
_sort_col_num = schema.sort_col_num();
_compression_type = schema.compression_type();
+ _schema_version = schema.schema_version();
}
-void TabletSchema::to_schema_pb(TabletSchemaPB* tablet_meta_pb) {
- tablet_meta_pb->set_keys_type(_keys_type);
+void TabletSchema::build_current_tablet_schema(int64_t index_id,
+ const POlapTableSchemaParam&
ptable_schema_param,
+ const TabletSchema&
ori_tablet_schema) {
+ // copy from ori_tablet_schema
+ _keys_type = ori_tablet_schema.keys_type();
Review Comment:
这里的逻辑我看也只有导入用到了，我们可不可以直接导入的时候优FE 生成PB 结构，这个逻辑感觉跟创建表的重合了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
