yiguolei commented on code in PR #10136:
URL: https://github.com/apache/doris/pull/10136#discussion_r912442441
##########
be/src/olap/schema_change.cpp:
##########
@@ -1649,8 +1650,8 @@ Status VSchemaChangeWithSorting::_internal_sorting(
MultiBlockMerger merger(new_tablet);
std::unique_ptr<RowsetWriter> rowset_writer;
- RETURN_IF_ERROR(
- new_tablet->create_rowset_writer(version, VISIBLE,
segments_overlap, &rowset_writer));
+ RETURN_IF_ERROR(new_tablet->create_rowset_writer(version, VISIBLE,
segments_overlap,
+
&new_tablet->tablet_schema(), &rowset_writer));
Review Comment:
If create rowset writer always bind the tablet's tablet_schema, then its no
need as an input parameter. We could get the tablet schema during
create_rowset_writer inside.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
