yiguolei commented on code in PR #47462: URL: https://github.com/apache/doris/pull/47462#discussion_r1966505475
########## be/src/runtime/memory/mem_tracker_limiter.h: ########## @@ -350,9 +369,16 @@ inline void MemTrackerLimiter::cache_consume(int64_t bytes) { } inline Status MemTrackerLimiter::check_limit(int64_t bytes) { - if (bytes <= 0 || (is_overcommit_tracker() && config::enable_query_memory_overcommit)) { + // Do not enable check limit, because reserve process will check it. + if (bytes <= 0 || _enable_reserve_memory) { Review Comment: 现在估计不太行,因为reserve 计算不准,这里得依靠hard limit 来gc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org