yiguolei commented on code in PR #47462: URL: https://github.com/apache/doris/pull/47462#discussion_r1966504475
########## be/src/common/daemon.cpp: ########## @@ -547,7 +550,9 @@ void Daemon::cache_adjust_capacity_thread() { doris::GlobalMemoryArbitrator::cache_adjust_capacity_cv.wait_for( l, std::chrono::milliseconds(100)); } - double adjust_weighted = GlobalMemoryArbitrator::last_cache_capacity_adjust_weighted; + double adjust_weighted = std::min<double>( + GlobalMemoryArbitrator::last_cache_capacity_adjust_weighted, + GlobalMemoryArbitrator::last_wg_trigger_cache_capacity_adjust_weighted); Review Comment: 这里是要直接降低到0.01% 或者说是禁用掉,跟那个递减的逻辑是分开的。而递减的逻辑可能永远都到达不了禁用,比如说,我process memory = 10g, used memory = 8g; 但是此时我要申请1.9g 内存,那么就会失败,但是我并没有真实占用很多内存,所以递减的逻辑就不会感知到我reserve 失败这个情况。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org