[GitHub] [doris] Gabriel39 commented on a diff in pull request #10367: [fix][storage]BetaRowsetReader::next_block does not return 0 rows before eof

[GitBox]

Gabriel39 commented on code in PR #10367:
URL: https://github.com/apache/doris/pull/10367#discussion_r904944243


##########
be/src/olap/rowset/beta_rowset_reader.cpp:
##########
@@ -184,15 +184,17 @@ Status BetaRowsetReader::next_block(RowBlock** block) {
 Status BetaRowsetReader::next_block(vectorized::Block* block) {
     SCOPED_RAW_TIMER(&_stats->block_fetch_ns);
     if (config::enable_storage_vectorization && _context->is_vec) {
-        auto s = _iterator->next_batch(block);
-        if (!s.ok()) {
-            if (s.is_end_of_file()) {
-                return Status::OLAPInternalError(OLAP_ERR_DATA_EOF);
-            } else {
-                LOG(WARNING) << "failed to read next block: " << s.to_string();
-                return Status::OLAPInternalError(OLAP_ERR_ROWSET_READ_FAILED);
+        do {
+            auto s = _iterator->next_batch(block);
+            if (!s.ok()) {
+                if (s.is_end_of_file()) {
+                    return Status::OLAPInternalError(OLAP_ERR_DATA_EOF);
+                } else {
+                    LOG(WARNING) << "failed to read next block: " << 
s.to_string();
+                    return 
Status::OLAPInternalError(OLAP_ERR_ROWSET_READ_FAILED);
+                }
             }
-        }
+        } while (block->rows() == 0);

Review Comment:
   After this PR, rows in block will never be 0 unless EOF. So maybe you also 
need to update codes in `_refresh_current_row`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org