dataroaring opened a new pull request, #10367: URL: https://github.com/apache/doris/pull/10367
Doris uses both Status::Eof and 0 rows as eof in iterators, it is a little messy. VCollectIterator::Level0Iterator::_refresh_current_row returns EOF when empty block is returned, then VCollectIterator::build_heap does not put the iterator to the heap. So if we have a rowset of which the first batch rows is filtered by pushed down predicates, then the rowset is not read any more. However, there may be valid rows after the first batch. # Proposed changes Issue Number: close #10366 ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior: (Yes/No/I Don't know) 2. Has unit tests been added: (Yes/No/No Need) 3. Has document been added or modified: (Yes/No/No Need) 4. Does it need to update dependencies: (Yes/No) 5. Are there any changes that cannot be rolled back: (Yes/No) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
