yiguolei commented on code in PR #44690:
URL: https://github.com/apache/doris/pull/44690#discussion_r1926450620
##########
be/src/vec/exec/scan/scanner_context.cpp:
##########
@@ -319,119 +315,47 @@ Status
ScannerContext::get_block_from_queue(RuntimeState* state, vectorized::Blo
return _process_status;
}
+ // No need to worry about small block, block is merged together when
they are appended to cached_blocks.
if (!scan_task->cached_blocks.empty()) {
auto [current_block, block_size] =
std::move(scan_task->cached_blocks.front());
scan_task->cached_blocks.pop_front();
- if (_estimated_block_size > block_size) {
- _estimated_block_size = block_size;
- }
_block_memory_usage -= block_size;
// consume current block
block->swap(*current_block);
Review Comment:
为啥不return了？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
