yiguolei commented on code in PR #44690:
URL: https://github.com/apache/doris/pull/44690#discussion_r1926326951
##########
be/src/vec/exec/scan/scanner_context.h:
##########
@@ -211,20 +228,29 @@ class ScannerContext : public
std::enable_shared_from_this<ScannerContext>,
RuntimeProfile::Counter* _scale_up_scanners_counter = nullptr;
QueryThreadContext _query_thread_context;
std::shared_ptr<pipeline::Dependency> _dependency = nullptr;
- bool _ignore_data_distribution = false;
- bool _is_file_scan_operator = false;
+ const bool _serial_scan_operator = false;
- // for scaling up the running scanners
- size_t _estimated_block_size = 0;
std::atomic<int64_t> _block_memory_usage = 0;
- int64_t _last_scale_up_time = 0;
- int64_t _last_fetch_time = 0;
- int64_t _total_wait_block_time = 0;
- double _last_wait_duration_ratio = 0;
- const int64_t SCALE_UP_DURATION = 5000; // 5000ms
- const float WAIT_BLOCK_DURATION_RATIO = 0.5;
- const float SCALE_UP_RATIO = 0.5;
- float MAX_SCALE_UP_RATIO;
+
+ // adaptive scan concurrency related
+
+ int32_t _min_concurrency_of_scan_scheduler;
+ int32_t _min_concurrency;
+ int32_t _max_concurrency = 0;
+ int32_t _basic_margin = 0;
+
+ [[nodiscard]] Status _schedule_scan_task(std::shared_ptr<ScanTask>
current_scan_task,
Review Comment:
这没有必要加nodiscard，status 这个类本身就是nodisacard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
