Gabriel39 commented on code in PR #10195:
URL: https://github.com/apache/incubator-doris/pull/10195#discussion_r899853021
##########
be/src/exprs/block_bloom_filter_impl.cc:
##########
@@ -83,17 +85,26 @@ Status BlockBloomFilter::init(const int log_space_bytes,
uint32_t hash_seed) {
return Status::OK();
}
-Status BlockBloomFilter::init_from_directory(int log_space_bytes, const Slice&
directory,
- bool always_false, uint32_t
hash_seed) {
+Status BlockBloomFilter::init_from_directory(int log_space_bytes,
+
butil::IOBufAsZeroCopyInputStream* data,
+ const size_t& data_size, bool
always_false,
+ uint32_t hash_seed) {
Review Comment:
I'm not sure if it's necessary. `data_size ` here only means bloom filter's
size so it may not be used anywhere. So do we really need to make this
abstract? I have some doubts for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
