[GitHub] [incubator-doris] cambyzju commented on a diff in pull request #10195: [Improvement] Use IOBufAsZeroCopyInputStream for bloom filter

[GitBox]

cambyzju commented on code in PR #10195:
URL: https://github.com/apache/incubator-doris/pull/10195#discussion_r899802595


##########
be/src/exprs/block_bloom_filter.hpp:
##########
@@ -202,6 +205,13 @@ class BlockBloomFilter {
         return (static_cast<uint64_t>(hash) * m + a) >> 32U;
     }
 
+#ifdef DISALLOW_COPY_AND_ASSIGN
+#undef DISALLOW_COPY_AND_ASSIGN
+#endif
+#define DISALLOW_COPY_AND_ASSIGN(TypeName) \
+    TypeName(const TypeName&) = delete;    \
+    void operator=(const TypeName&) = delete
+
     DISALLOW_COPY_AND_ASSIGN(BlockBloomFilter);

Review Comment:
   ```suggestion
      BlockBloomFilter(const BlockBloomFilter&) = delete;
      void operator=(const BlockBloomFilter&) = delete;
   ```
   
   just expand it, it looks like more simpler.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org