Re: [PR] [improvement](memory) Storage page cache use LRU-K cache, K=2 [doris]

[via GitHub]

xinyiZzz commented on code in PR #45719:
URL: https://github.com/apache/doris/pull/45719#discussion_r1895729000


##########
be/src/olap/lru_cache.cpp:
##########
@@ -419,13 +474,18 @@ Cache::Handle* LRUCache::insert(const CacheKey& key, 
uint32_t hash, void* value,
     // because charge at this time is no longer the memory size, but an weight.
     e->total_size = (_type == LRUCacheType::SIZE ? handle_size + charge : 
charge);
     e->hash = hash;
-    e->refs = 2; // one for the returned handle, one for LRUCache.
+    e->refs = 1; // only one for the returned handle.
     e->next = e->prev = nullptr;
-    e->in_cache = true;
+    e->in_cache = false;
     e->priority = priority;
     e->type = _type;
     memcpy(e->key_data, key.data(), key.size());
     e->last_visit_time = UnixMillis();
+
+    if (_is_lru_k && _lru_k_insert_visits_list(e->total_size, hash)) {

Review Comment:
   因为 key 可能很长，key的长度是没有限制的，所以是先比较 hash 值，再比较 key
   
![image](https://github.com/user-attachments/assets/b02fc2aa-651c-47e1-acf3-2ae5855b151f)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org