yiguolei commented on code in PR #45719:
URL: https://github.com/apache/doris/pull/45719#discussion_r1895708455
##########
be/src/olap/lru_cache.cpp:
##########
@@ -419,13 +474,18 @@ Cache::Handle* LRUCache::insert(const CacheKey& key,
uint32_t hash, void* value,
// because charge at this time is no longer the memory size, but an weight.
e->total_size = (_type == LRUCacheType::SIZE ? handle_size + charge :
charge);
e->hash = hash;
- e->refs = 2; // one for the returned handle, one for LRUCache.
+ e->refs = 1; // only one for the returned handle.
e->next = e->prev = nullptr;
- e->in_cache = true;
+ e->in_cache = false;
e->priority = priority;
e->type = _type;
memcpy(e->key_data, key.data(), key.size());
e->last_visit_time = UnixMillis();
+
+ if (_is_lru_k && _lru_k_insert_visits_list(e->total_size, hash)) {
Review Comment:
为啥这里是判断hash 值，而不是判断key？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
