wangbo commented on code in PR #8855:
URL: https://github.com/apache/incubator-doris/pull/8855#discussion_r849452732
##########
be/src/olap/rowset/column_data.cpp:
##########
@@ -138,13 +138,13 @@ OLAPStatus ColumnData::_seek_to_block(const
RowBlockPosition& block_pos, bool wi
_lru_cache, _runtime_state, _stats);
if (_segment_reader == nullptr) {
OLAP_LOG_WARNING("fail to malloc segment reader.");
- return OLAP_ERR_MALLOC_ERROR;
+ return Status::OLAPInternalError(OLAP_ERR_MALLOC_ERROR);
}
_current_segment = block_pos.segment;
auto res = _segment_reader->init(_is_using_cache);
- if (OLAP_SUCCESS != res) {
- OLAP_LOG_WARNING("fail to init segment reader. [res=%d]", res);
+ if (!res.ok()) {
+ LOG(WARNING) << "fail to init segment reader. res = " << res;
Review Comment:
Why not using OLAP_LOG_WARNING?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
