yiguolei commented on code in PR #8855:
URL: https://github.com/apache/incubator-doris/pull/8855#discussion_r849386631
##########
be/src/olap/delete_handler.cpp:
##########
@@ -48,20 +48,20 @@ using google::protobuf::RepeatedPtrField;
namespace doris {
-OLAPStatus DeleteConditionHandler::generate_delete_predicate(
+Status DeleteConditionHandler::generate_delete_predicate(
const TabletSchema& schema, const std::vector<TCondition>& conditions,
DeletePredicatePB* del_pred) {
if (conditions.empty()) {
LOG(WARNING) << "invalid parameters for store_cond."
<< " condition_size=" << conditions.size();
- return OLAP_ERR_DELETE_INVALID_PARAMETERS;
+ return Status::OLAPInternalError(OLAP_ERR_DELETE_INVALID_PARAMETERS);
}
// Check whether the delete condition meets the requirements
for (const TCondition& condition : conditions) {
- if (check_condition_valid(schema, condition) != OLAP_SUCCESS) {
+ if (check_condition_valid(schema, condition) != Status::OK()) {
LOG(WARNING) << "invalid condition. condition=" <<
ThriftDebugString(condition);
- return OLAP_ERR_DELETE_INVALID_CONDITION;
+ return
Status::OLAPInternalError(OLAP_ERR_DELETE_INVALID_CONDITION);
Review Comment:
Actually, I do not know. I think we'd better not change logic in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
