englefly commented on a change in pull request #8618:
URL: https://github.com/apache/incubator-doris/pull/8618#discussion_r836540483
##########
File path: fe/fe-core/src/main/java/org/apache/doris/planner/HashJoinNode.java
##########
@@ -165,6 +170,54 @@ public void setColocate(boolean colocate, String reason) {
colocateReason = reason;
}
+ // output slots + conjunct slots + other conjunct slots = hash output slots
Review comment:
why conjunct slots are output slots?
there is an example in comments (line 882)
* Query: select a.k1 from a, b where a.k1=b.k1
* output slots: a.k1
in my understanding, conjunct is a.k1=b.k1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
