morningman commented on a change in pull request #8618:
URL: https://github.com/apache/incubator-doris/pull/8618#discussion_r834093523
##########
File path: fe/fe-core/src/main/java/org/apache/doris/planner/PlanNode.java
##########
@@ -870,4 +869,23 @@ public void convertToVectoriezd() {
child.convertToVectoriezd();
}
}
+
+ // The slotIdSet could be null
+ // The output slots is subset of required slots when there are more than
one child
+ public void initOutputSlotIds(Set<SlotId> requiredSlotIdSet, Analyzer
analyzer) throws NotImplementedException {
+ throw new NotImplementedException("The `initOutputSlotIds` hasn't been
implemented in " + planNodeName);
+ }
+
+ public Set<SlotId> computeInputSlotIds() throws NotImplementedException {
Review comment:
Add comment for these 2 new interface.
##########
File path: fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java
##########
@@ -176,6 +176,9 @@
public static final String BLOCK_ENCRYPTION_MODE = "block_encryption_mode";
+ // TODO(ml): change to all node project
+ public static final String ENABLE_HASH_PROJECT = "enable_hash_project";
Review comment:
```suggestion
public static final String ENABLE_PROJECTION = "enable_projection";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
