[GitHub] [incubator-doris] weizuo93 commented on a change in pull request #8387: [Refactor](storage_engine) Use std::shared_mutex to replace RWMutex

[GitBox]

weizuo93 commented on a change in pull request #8387:
URL: https://github.com/apache/incubator-doris/pull/8387#discussion_r823300070



##########
File path: be/src/olap/txn_manager.cpp
##########
@@ -357,7 +357,7 @@ OLAPStatus TxnManager::delete_txn(OlapMeta* meta, 
TPartitionId partition_id,
                                   SchemaHash schema_hash, TabletUid 
tablet_uid) {
     pair<int64_t, int64_t> key(partition_id, transaction_id);
     TabletInfo tablet_info(tablet_id, schema_hash, tablet_uid);
-    WriteLock txn_wrlock(&_get_txn_map_lock(transaction_id));
+    WriteLock txn_wlock(_get_txn_map_lock(transaction_id));

Review comment:
       Is `txn_wrlock`better?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org