caiconghui commented on a change in pull request #8387: URL: https://github.com/apache/incubator-doris/pull/8387#discussion_r821476759
########## File path: be/src/olap/push_handler.cpp ########## @@ -116,11 +118,12 @@ OLAPStatus PushHandler::_do_streaming_ingestion(TabletSharedPtr tablet, const TP DeletePredicatePB del_pred; DeleteConditionHandler del_cond_handler; - tablet_var.tablet->obtain_header_rdlock(); - res = del_cond_handler.generate_delete_predicate(tablet_var.tablet->tablet_schema(), - request.delete_conditions, &del_pred); - del_preds.push(del_pred); - tablet_var.tablet->release_header_lock(); + { Review comment: to make rdlock release after } -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org