EmmyMiao87 commented on a change in pull request #8299: URL: https://github.com/apache/incubator-doris/pull/8299#discussion_r818435085
########## File path: fe/fe-core/src/main/cup/sql_parser.cup ########## @@ -4743,6 +4743,10 @@ function_call_expr ::= RESULT = new FunctionCallExpr(fn_name, params); } :} + | function_name:fn_name LPAREN function_params:left_params RPAREN LPAREN function_params:params RPAREN Review comment: 1. From the point of view of function capabilities, single parentheses can meet the needs. For example, ```intersect count``` is currently implemented in this way. 2. From the perspective of grammar compatibility, it depends on whether you want to follow the consistent syntax style of Doris or cater to CK. In fact, much of the grammar of CK is not generic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org