dataroaring commented on a change in pull request #8299:
URL: https://github.com/apache/incubator-doris/pull/8299#discussion_r818427464



##########
File path: fe/fe-core/src/main/cup/sql_parser.cup
##########
@@ -4743,6 +4743,10 @@ function_call_expr ::=
       RESULT = new FunctionCallExpr(fn_name, params);
     }
   :}
+  | function_name:fn_name LPAREN function_params:left_params RPAREN LPAREN 
function_params:params RPAREN

Review comment:
       yeah, discussions are needed here on the grammar. I was considering that 
we could extends the function by adding modes parameter in ck, so I used 
()()gramma like ck.  If we use gramma with two brackets, then we can add modes 
parameters with backward compatibility.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to