github-actions[bot] commented on code in PR #36649: URL: https://github.com/apache/doris/pull/36649#discussion_r1650651189
########## be/src/vec/functions/function_decode_varchar.cpp: ########## @@ -0,0 +1,135 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include <fmt/core.h> Review Comment: warning: 'fmt/core.h' file not found [clang-diagnostic-error] ```cpp #include <fmt/core.h> ^ ``` ########## be/src/vec/functions/function_decode_varchar.cpp: ########## @@ -0,0 +1,135 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include <fmt/core.h> + +#include <cstddef> +#include <limits> +#include <type_traits> + +#include "common/exception.h" +#include "common/status.h" +#include "runtime/primitive_type.h" +#include "vec/columns/column_const.h" +#include "vec/columns/column_vector.h" +#include "vec/core/types.h" +#include "vec/data_types/data_type.h" +#include "vec/data_types/data_type_number.h" +#include "vec/data_types/data_type_string.h" +#include "vec/functions/function.h" +#include "vec/functions/function_helpers.h" +#include "vec/functions/simple_function_factory.h" + +namespace doris::vectorized { + +template <typename IntegerType> +class FunctionDecodeAsVarchar : public IFunction { + static inline void reverse_copy_bytes(UInt8* __restrict desc, size_t desc_len, const void* src, + size_t src_len) { + if (src_len == 0) { + return; + } + + auto _src = static_cast<const UInt8*>(src); + + for (int i = desc_len - 1, j = 0; j < src_len; --i, ++j) { + desc[i] = _src[j]; + } + } + +public: + static constexpr auto name = "decode_as_varchar"; + static FunctionPtr create() { return std::make_shared<FunctionDecodeAsVarchar>(); } + + String get_name() const override { return name; } + + size_t get_number_of_arguments() const override { return 1; } + + bool is_variadic() const override { return true; } + + DataTypes get_variadic_argument_types_impl() const override { + if constexpr (std::is_same_v<IntegerType, Int16>) { + return {std::make_shared<DataTypeInt16>()}; + } else if constexpr (std::is_same_v<IntegerType, Int32>) { + return {std::make_shared<DataTypeInt32>()}; + } else if constexpr (std::is_same_v<IntegerType, Int64>) { + return {std::make_shared<DataTypeInt64>()}; + } else if constexpr (std::is_same_v<IntegerType, Int128>) { + return {std::make_shared<DataTypeInt128>()}; + } else { + throw doris::Exception(ErrorCode::INVALID_ARGUMENT, "Invalid IntegerType"); + } + } + + DataTypePtr get_return_type_impl(const DataTypes& arguments) const override { + if (arguments.size() != 1) { + throw doris::Exception(ErrorCode::INVALID_ARGUMENT, + "Function {} requires 1 arguments, got {}", name, + arguments.size()); + } + + return std::make_shared<DataTypeString>(); + } + + Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments, + size_t result, size_t input_rows_count) const override { + const ColumnVector<IntegerType>* col_source = assert_cast<const ColumnVector<IntegerType>*>( + block.get_by_position(arguments[0]).column.get()); + + auto col_res = ColumnString::create(); + + ColumnString::Chars& col_res_data = col_res->get_chars(); + ColumnString::Offsets& col_res_offset = col_res->get_offsets(); + col_res_data.resize(input_rows_count * sizeof(IntegerType)); + col_res_offset.resize(input_rows_count); + + for (Int32 i = 0; i < input_rows_count; ++i) { + IntegerType value = col_source->get_element(i); + const UInt8* const __restrict ui8_ptr = reinterpret_cast<const UInt8*>(&value); Review Comment: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto] ```suggestion const auto* const __restrict ui8_ptr = reinterpret_cast<const UInt8*>(&value); ``` ########## be/src/vec/functions/function_encode_varchar.cpp: ########## @@ -0,0 +1,128 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include <cstddef> +#include <limits> +#include <type_traits> + +#include "common/exception.h" +#include "common/status.h" +#include "runtime/primitive_type.h" +#include "vec/columns/column_const.h" +#include "vec/columns/column_vector.h" +#include "vec/core/types.h" +#include "vec/data_types/data_type.h" +#include "vec/data_types/data_type_number.h" +#include "vec/data_types/data_type_string.h" +#include "vec/functions/function.h" +#include "vec/functions/function_helpers.h" +#include "vec/functions/simple_function_factory.h" + +namespace doris::vectorized { + +struct EncodeAsSmallInt { + static constexpr auto name = "encode_as_smallint"; +}; + +struct EncodeAsInt { + static constexpr auto name = "encode_as_int"; +}; + +struct EncodeAsBigInt { + static constexpr auto name = "encode_as_bigint"; +}; + +struct EncodeAsLargeInt { + static constexpr auto name = "encode_as_largeint"; +}; + +template <typename Name, typename ReturnType> +class FunctionEncodeVarchar : public IFunction { +private: + static inline void reverse_copy_bytes(UInt8* __restrict desc, size_t desc_len, const void* src, + size_t str_len) { + if (str_len == 0) { + return; + } + + auto _src = static_cast<const UInt8*>(src); + + for (int i = desc_len - 1, j = 0; j < str_len; --i, ++j) { + desc[i] = _src[j]; + } + } + +public: + static constexpr auto name = Name::name; + static FunctionPtr create() { return std::make_shared<FunctionEncodeVarchar>(); } + + String get_name() const override { return name; } + + size_t get_number_of_arguments() const override { return 1; } + + DataTypePtr get_return_type_impl(const DataTypes& arguments) const override { + return std::make_shared<DataTypeNumber<ReturnType>>(); + } + + Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments, + size_t result, size_t input_rows_count) const override { + const ColumnString* col_str = + assert_cast<const ColumnString*>(block.get_by_position(arguments[0]).column.get()); + + // max_row_byte_size = size of string + size of offset value + size_t max_str_size = col_str->get_max_row_byte_size() - sizeof(UInt32); + + if (max_str_size > sizeof(ReturnType) - 1) { + return Status::InternalError( + "String is too long to encode, input string size {}, max valid string " + "size for {} is {}", + max_str_size, name, sizeof(ReturnType) - 1); + } + + auto col_res = ColumnVector<ReturnType>::create(input_rows_count, 0); + auto& col_res_data = col_res->get_data(); + + for (size_t i = 0; i < input_rows_count; ++i) { + const char* str_ptr = col_str->get_data_at(i).data; + UInt8 str_size = static_cast<UInt8>(col_str->get_data_at(i).size); Review Comment: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto] ```suggestion auto str_size = static_cast<UInt8>(col_str->get_data_at(i).size); ``` ########## be/src/vec/functions/function_encode_varchar.cpp: ########## @@ -0,0 +1,128 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include <cstddef> +#include <limits> +#include <type_traits> + +#include "common/exception.h" +#include "common/status.h" +#include "runtime/primitive_type.h" +#include "vec/columns/column_const.h" +#include "vec/columns/column_vector.h" +#include "vec/core/types.h" +#include "vec/data_types/data_type.h" +#include "vec/data_types/data_type_number.h" +#include "vec/data_types/data_type_string.h" +#include "vec/functions/function.h" +#include "vec/functions/function_helpers.h" +#include "vec/functions/simple_function_factory.h" + +namespace doris::vectorized { + +struct EncodeAsSmallInt { + static constexpr auto name = "encode_as_smallint"; +}; + +struct EncodeAsInt { + static constexpr auto name = "encode_as_int"; +}; + +struct EncodeAsBigInt { + static constexpr auto name = "encode_as_bigint"; +}; + +struct EncodeAsLargeInt { + static constexpr auto name = "encode_as_largeint"; +}; + +template <typename Name, typename ReturnType> +class FunctionEncodeVarchar : public IFunction { +private: + static inline void reverse_copy_bytes(UInt8* __restrict desc, size_t desc_len, const void* src, + size_t str_len) { + if (str_len == 0) { + return; + } + + auto _src = static_cast<const UInt8*>(src); Review Comment: warning: 'auto _src' can be declared as 'const auto *_src' [readability-qualified-auto] ```suggestion const auto *_src = static_cast<const UInt8*>(src); ``` ########## be/src/vec/functions/function_decode_varchar.cpp: ########## @@ -0,0 +1,135 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include <fmt/core.h> + +#include <cstddef> +#include <limits> +#include <type_traits> + +#include "common/exception.h" +#include "common/status.h" +#include "runtime/primitive_type.h" +#include "vec/columns/column_const.h" +#include "vec/columns/column_vector.h" +#include "vec/core/types.h" +#include "vec/data_types/data_type.h" +#include "vec/data_types/data_type_number.h" +#include "vec/data_types/data_type_string.h" +#include "vec/functions/function.h" +#include "vec/functions/function_helpers.h" +#include "vec/functions/simple_function_factory.h" + +namespace doris::vectorized { + +template <typename IntegerType> +class FunctionDecodeAsVarchar : public IFunction { + static inline void reverse_copy_bytes(UInt8* __restrict desc, size_t desc_len, const void* src, + size_t src_len) { + if (src_len == 0) { + return; + } + + auto _src = static_cast<const UInt8*>(src); Review Comment: warning: 'auto _src' can be declared as 'const auto *_src' [readability-qualified-auto] ```suggestion const auto *_src = static_cast<const UInt8*>(src); ``` ########## be/src/vec/functions/function_encode_varchar.cpp: ########## @@ -0,0 +1,128 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include <cstddef> +#include <limits> +#include <type_traits> + +#include "common/exception.h" +#include "common/status.h" +#include "runtime/primitive_type.h" +#include "vec/columns/column_const.h" +#include "vec/columns/column_vector.h" +#include "vec/core/types.h" +#include "vec/data_types/data_type.h" +#include "vec/data_types/data_type_number.h" +#include "vec/data_types/data_type_string.h" +#include "vec/functions/function.h" +#include "vec/functions/function_helpers.h" +#include "vec/functions/simple_function_factory.h" + +namespace doris::vectorized { + +struct EncodeAsSmallInt { + static constexpr auto name = "encode_as_smallint"; +}; + +struct EncodeAsInt { + static constexpr auto name = "encode_as_int"; +}; + +struct EncodeAsBigInt { + static constexpr auto name = "encode_as_bigint"; +}; + +struct EncodeAsLargeInt { + static constexpr auto name = "encode_as_largeint"; +}; + +template <typename Name, typename ReturnType> +class FunctionEncodeVarchar : public IFunction { +private: + static inline void reverse_copy_bytes(UInt8* __restrict desc, size_t desc_len, const void* src, + size_t str_len) { + if (str_len == 0) { + return; + } + + auto _src = static_cast<const UInt8*>(src); + + for (int i = desc_len - 1, j = 0; j < str_len; --i, ++j) { + desc[i] = _src[j]; + } + } + +public: + static constexpr auto name = Name::name; + static FunctionPtr create() { return std::make_shared<FunctionEncodeVarchar>(); } + + String get_name() const override { return name; } + + size_t get_number_of_arguments() const override { return 1; } + + DataTypePtr get_return_type_impl(const DataTypes& arguments) const override { + return std::make_shared<DataTypeNumber<ReturnType>>(); + } + + Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments, + size_t result, size_t input_rows_count) const override { + const ColumnString* col_str = + assert_cast<const ColumnString*>(block.get_by_position(arguments[0]).column.get()); + + // max_row_byte_size = size of string + size of offset value + size_t max_str_size = col_str->get_max_row_byte_size() - sizeof(UInt32); + + if (max_str_size > sizeof(ReturnType) - 1) { + return Status::InternalError( + "String is too long to encode, input string size {}, max valid string " + "size for {} is {}", + max_str_size, name, sizeof(ReturnType) - 1); + } + + auto col_res = ColumnVector<ReturnType>::create(input_rows_count, 0); + auto& col_res_data = col_res->get_data(); + + for (size_t i = 0; i < input_rows_count; ++i) { + const char* str_ptr = col_str->get_data_at(i).data; + UInt8 str_size = static_cast<UInt8>(col_str->get_data_at(i).size); + ReturnType* res = &col_res_data[i]; + UInt8* __restrict ui8_ptr = reinterpret_cast<UInt8*>(res); Review Comment: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto] ```suggestion auto* __restrict ui8_ptr = reinterpret_cast<UInt8*>(res); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
