HappenLee commented on code in PR #36649: URL: https://github.com/apache/doris/pull/36649#discussion_r1650287589
########## be/src/vec/functions/function_compress_varchar.cpp: ########## @@ -0,0 +1,130 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include <cstddef> +#include <limits> +#include <type_traits> + +#include "common/exception.h" +#include "common/status.h" +#include "runtime/primitive_type.h" +#include "vec/columns/column_const.h" +#include "vec/columns/column_vector.h" +#include "vec/core/types.h" +#include "vec/data_types/data_type.h" +#include "vec/data_types/data_type_number.h" +#include "vec/data_types/data_type_string.h" +#include "vec/functions/function.h" +#include "vec/functions/function_helpers.h" +#include "vec/functions/simple_function_factory.h" + +namespace doris::vectorized { + +struct CompressAsSmallInt { + static constexpr auto name = "compress_as_smallint"; +}; + +struct CompressAsInt { + static constexpr auto name = "compress_as_int"; +}; + +struct CompressAsBigInt { + static constexpr auto name = "compress_as_bigint"; +}; + +struct CompressAsLargeInt { + static constexpr auto name = "compress_as_largeint"; +}; + +template <typename Name, typename ReturnType> +class FunctionCompressVarchar : public IFunction { +private: + static inline void reverse_bytes(uint8_t* __restrict s, size_t length) { + if (length == 0) { + return; + } + + int c, i, j; + + for (i = 0, j = length - 1; i < j; i++, j--) { + c = s[i]; + s[i] = s[j]; + s[j] = c; + } + } + +public: + static constexpr auto name = Name::name; + static FunctionPtr create() { return std::make_shared<FunctionCompressVarchar>(); } + + String get_name() const override { return name; } + + size_t get_number_of_arguments() const override { return 1; } + + DataTypePtr get_return_type_impl(const DataTypes& arguments) const override { + return std::make_shared<DataTypeNumber<ReturnType>>(); + } + + Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments, + size_t result, size_t input_rows_count) const override { + const ColumnString* col_str = + assert_cast<const ColumnString*>(block.get_by_position(arguments[0]).column.get()); + + // max_row_byte_size = size of string + size of offset value + size_t max_str_size = col_str->get_max_row_byte_size() - sizeof(UInt32); + + if (max_str_size > sizeof(ReturnType) - 1) { + return Status::InternalError( + "String is too long to compress, input string size {}, max valid string " + "size for {} is {}", + max_str_size, name, sizeof(ReturnType) - 1); + } + + auto col_res = ColumnVector<ReturnType>::create(input_rows_count, 0); + auto& col_res_data = col_res->get_data(); + + for (size_t i = 0; i < input_rows_count; ++i) { + const char* str_ptr = col_str->get_data_at(i).data; + UInt8 str_size = static_cast<UInt8>(col_str->get_data_at(i).size); + ReturnType* res = &col_res_data[i]; + UInt8* __restrict ui8_ptr = reinterpret_cast<UInt8*>(res); + + memcpy(ui8_ptr, str_ptr, str_size); Review Comment: why here direct reverse copy, need do work twice? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
