[GitHub] [incubator-doris] hf200012 commented on a change in pull request #8247: [refactor] Upgrade to MySQL 5.7.37 to reduce unnecessary CVE issues

[GitBox]

hf200012 commented on a change in pull request #8247:
URL: https://github.com/apache/incubator-doris/pull/8247#discussion_r815293589



##########
File path: fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java
##########
@@ -50,6 +50,9 @@
     public static final String RESOURCE_VARIABLE = "resource_group";
     public static final String AUTO_COMMIT = "autocommit";
     public static final String TX_ISOLATION = "tx_isolation";
+    public static final String TX_READ_ONLY = "tx_read_only";
+       public static final String TRANSACTION_READ_ONLY = 
"transaction_read_only";

Review comment:
       ```suggestion
       public static final String TRANSACTION_READ_ONLY = 
"transaction_read_only";
   ```

##########
File path: fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java
##########
@@ -973,6 +1000,9 @@ private void readFromStream(DataInput in) throws 
IOException {
         charsetConnection = Text.readString(in);
         charsetClient = Text.readString(in);
         txIsolation = Text.readString(in);
+           transactionIsolation = Text.readString(in);

Review comment:
       ```suggestion
          transactionIsolation = Text.readString(in);
   ```

##########
File path: fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java
##########
@@ -973,6 +1000,9 @@ private void readFromStream(DataInput in) throws 
IOException {
         charsetConnection = Text.readString(in);
         charsetClient = Text.readString(in);
         txIsolation = Text.readString(in);
+           transactionIsolation = Text.readString(in);
+               txReadonly = in.readBoolean();
+               transactionReadonly = in.readBoolean();

Review comment:
       code format

##########
File path: fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java
##########
@@ -973,6 +1000,9 @@ private void readFromStream(DataInput in) throws 
IOException {
         charsetConnection = Text.readString(in);
         charsetClient = Text.readString(in);
         txIsolation = Text.readString(in);
+           transactionIsolation = Text.readString(in);
+               txReadonly = in.readBoolean();
+               transactionReadonly = in.readBoolean();

Review comment:
       ```suggestion
   transactionReadonly = in.readBoolean();
   ```

##########
File path: fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java
##########
@@ -50,6 +50,9 @@
     public static final String RESOURCE_VARIABLE = "resource_group";
     public static final String AUTO_COMMIT = "autocommit";
     public static final String TX_ISOLATION = "tx_isolation";
+    public static final String TX_READ_ONLY = "tx_read_only";
+       public static final String TRANSACTION_READ_ONLY = 
"transaction_read_only";
+       public static final String TRANSACTION_ISOLATION = 
"transaction_isolation";

Review comment:
       ```suggestion
       public static final String TRANSACTION_ISOLATION = 
"transaction_isolation";
   ```

##########
File path: fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java
##########
@@ -973,6 +1000,9 @@ private void readFromStream(DataInput in) throws 
IOException {
         charsetConnection = Text.readString(in);
         charsetClient = Text.readString(in);
         txIsolation = Text.readString(in);
+           transactionIsolation = Text.readString(in);
+               txReadonly = in.readBoolean();

Review comment:
       ```suggestion
   txReadonly = in.readBoolean();
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org