morningman commented on a change in pull request #8247:
URL: https://github.com/apache/incubator-doris/pull/8247#discussion_r815295347
##########
File path: fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java
##########
@@ -50,6 +50,9 @@
public static final String RESOURCE_VARIABLE = "resource_group";
public static final String AUTO_COMMIT = "autocommit";
public static final String TX_ISOLATION = "tx_isolation";
+ public static final String TX_READ_ONLY = "tx_read_only";
+ public static final String TRANSACTION_READ_ONLY =
"transaction_read_only";
Review comment:
tab to space
##########
File path:
fe/fe-core/src/main/java/org/apache/doris/mysql/MysqlHandshakePacket.java
##########
@@ -23,7 +23,7 @@
// Version of handshake packet, since MySQL 3.21.0, Handshake of protocol
10 is used
private static final int PROTOCOL_VERSION = 10;
// JDBC uses this version to check which protocol the server support
- private static final String SERVER_VERSION = "5.1.73";
+ private static final String SERVER_VERSION = "5.7.37";
Review comment:
```suggestion
public static final String SERVER_VERSION = "5.7.37";
```
##########
File path: fe/fe-core/src/main/java/org/apache/doris/qe/GlobalVariable.java
##########
@@ -47,7 +47,7 @@
Version.DORIS_BUILD_VERSION + "-" + Version.DORIS_BUILD_SHORT_HASH;
@VariableMgr.VarAttr(name = VERSION, flag = VariableMgr.READ_ONLY)
- public static String version = "5.1.0";
+ public static String version = "5.7.37";
Review comment:
```suggestion
public static String version = MysqlHandshakePacket.SERVER_VERSION
```
##########
File path: fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java
##########
@@ -456,7 +471,19 @@ public void setSqlMode(long sqlMode) {
public boolean isAutoCommit() {
return autoCommit;
}
+
+ public boolean isTxReadonly() {
Review comment:
tab to space
##########
File path: fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java
##########
@@ -973,6 +1000,9 @@ private void readFromStream(DataInput in) throws
IOException {
charsetConnection = Text.readString(in);
charsetClient = Text.readString(in);
txIsolation = Text.readString(in);
+ transactionIsolation = Text.readString(in);
Review comment:
This method is deprecated, no need to modify it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
