yiguolei commented on a change in pull request #8042:
URL: https://github.com/apache/incubator-doris/pull/8042#discussion_r806439574



##########
File path: be/src/service/doris_main.cpp
##########
@@ -74,6 +79,199 @@ static void thrift_output(const char* x) {
 
 } // namespace doris
 
+// These code is referenced from clickhouse

Review comment:
       1. These code is not utils, they will be only used in the main function 
and could not in other functions. There maybe some signal catching problem if 
running in other functions I have not test it.
   2. These code should run at the beginning of the program so I add 
__attribute__(priority = 101) to checker. If other functions running before 
these code meet SIMD code and could not find the SSE instruction the program 
may crash we could not catch the signal.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to