morningman commented on a change in pull request #8042:
URL: https://github.com/apache/incubator-doris/pull/8042#discussion_r806436781



##########
File path: be/src/service/doris_main.cpp
##########
@@ -74,6 +79,199 @@ static void thrift_output(const char* x) {
 
 } // namespace doris
 
+// These code is referenced from clickhouse

Review comment:
       Can these code be moved to a separated file. like 
`util/instruction_utils.hpp`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to