superdiaodiao commented on code in PR #34391:
URL: https://github.com/apache/doris/pull/34391#discussion_r1590289729
##########
be/src/vec/functions/round.h:
##########
@@ -696,49 +679,236 @@ class FunctionRounding : public IFunction {
return Status::OK();
}
- ColumnNumbers get_arguments_that_are_always_constant() const override {
return {1}; }
+ ColumnNumbers get_arguments_that_are_always_constant() const override {
return {}; }
Review Comment:
In the CR of [PR#32746](https://github.com/apache/doris/pull/32746), the
author responded to the same question, which is:
> It must be override. Since function_rounding, instread of IFuntion, is the
base class and it has already implemented another retrun result.
And I keep the same behavior in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
