HappenLee commented on code in PR #34391:
URL: https://github.com/apache/doris/pull/34391#discussion_r1590287400
##########
be/src/vec/functions/round.h:
##########
@@ -696,49 +679,236 @@ class FunctionRounding : public IFunction {
return Status::OK();
}
- ColumnNumbers get_arguments_that_are_always_constant() const override {
return {1}; }
+ ColumnNumbers get_arguments_that_are_always_constant() const override {
return {}; }
+ // SELECT number, func(123.345, 1) FROM numbers("number"="10")
+ // should NOT behave like two column arguments, so we can not use const
column default implementation
+ bool use_default_implementation_for_constants() const override { return
false; }
Review Comment:
which case should not use default impl of constant? seems wired? if not
override the func, do not need dispose the case:0. func(ColumnConst,
ColumnConst)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
