github-actions[bot] commented on code in PR #33493:
URL: https://github.com/apache/doris/pull/33493#discussion_r1560661004
##########
be/src/vec/columns/column_struct.h:
##########
@@ -88,6 +88,8 @@ class ColumnStruct final : public COWHelper<IColumn,
ColumnStruct> {
MutableColumnPtr clone_resized(size_t size) const override;
size_t size() const override { return columns.at(0)->size(); }
+ bool is_variable_length() const override { return true; }
Review Comment:
warning: method 'is_variable_length' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static bool is_variable_length() override { return true; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
