eldenmoon commented on code in PR #33493:
URL: https://github.com/apache/doris/pull/33493#discussion_r1560407874
##########
be/src/vec/columns/column_array.cpp:
##########
@@ -412,6 +412,24 @@ void ColumnArray::insert(const Field& x) {
}
}
+void ColumnArray::replace(const Field& f, size_t self_row) {
+ const auto& array = f.get<const Array&>();
+ if (self_row == 0) {
+ // we should clear data because we call resize() before
replace_column_data()
+ data->clear();
+ }
+ if (f.is_null()) {
+ get_data().insert(Null());
+ get_offsets().push_back(get_offsets().back() + 1);
+ } else {
+ get_offsets()[self_row] = get_offsets()[self_row - 1] + array.size();
+ // we make sure call replace_column_data() by order so, here we just
insert for nested
+ for (const auto& i : array) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
