yiguolei commented on code in PR #32783:
URL: https://github.com/apache/doris/pull/32783#discussion_r1537349846
##########
be/src/pipeline/exec/partitioned_hash_join_probe_operator.cpp:
##########
@@ -147,11 +147,27 @@ Status
PartitionedHashJoinProbeLocalState::open(RuntimeState* state) {
RETURN_IF_ERROR(PipelineXLocalStateBase::open(state));
return _partitioner->open(state);
}
+
Status PartitionedHashJoinProbeLocalState::close(RuntimeState* state) {
RETURN_IF_ERROR(JoinProbeLocalState::close(state));
+ LOG(INFO) << "here begin to shutdown all thread pool tokens.";
+ for (auto& token : _spilling_tokens) {
+ token.second->shutdown();
Review Comment:
In pipelinex engine, we should use dependency to signal that all IO has
finished.
And if you want to cancel the io thread, then do not need wait. Using task
execution context weak ptr.
You could refer async_result_Writer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
