github-actions[bot] commented on code in PR #32783:
URL: https://github.com/apache/doris/pull/32783#discussion_r1537328522
##########
be/src/pipeline/exec/partitioned_hash_join_probe_operator.cpp:
##########
@@ -147,11 +147,27 @@ Status
PartitionedHashJoinProbeLocalState::open(RuntimeState* state) {
RETURN_IF_ERROR(PipelineXLocalStateBase::open(state));
return _partitioner->open(state);
}
+
Status PartitionedHashJoinProbeLocalState::close(RuntimeState* state) {
RETURN_IF_ERROR(JoinProbeLocalState::close(state));
+ LOG(INFO) << "here begin to shutdown all thread pool tokens.";
+ for (auto& token : _spilling_tokens) {
+ token.second->shutdown();
+ token.second->wait();
+ }
+ LOG(INFO) << "wait for all thread pool tokens done.";
return Status::OK();
}
+ThreadPoolToken* PartitionedHashJoinProbeLocalState::_get_or_create_token(
Review Comment:
warning: method '_get_or_create_token' can be made static
[readability-convert-member-functions-to-static]
be/src/pipeline/exec/partitioned_hash_join_probe_operator.h:70:
```diff
- ThreadPoolToken* _get_or_create_token(ThreadPool* thread_pool,
+ static ThreadPoolToken* _get_or_create_token(ThreadPool* thread_pool,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
