github-actions[bot] commented on code in PR #32355: URL: https://github.com/apache/doris/pull/32355#discussion_r1531725624
########## be/src/olap/rowset/segment_v2/bloom_filter_index_writer.h: ########## @@ -76,7 +76,14 @@ class PrimaryKeyBloomFilterIndexWriterImpl : public BloomFilterIndexWriter { _has_null(false), _bf_buffer_size(0) {} - ~PrimaryKeyBloomFilterIndexWriterImpl() override = default; + ~PrimaryKeyBloomFilterIndexWriterImpl() override { Review Comment: warning: use '= default' to define a trivial destructor [modernize-use-equals-default] ```cpp ~PrimaryKeyBloomFilterIndexWriterImpl() override { ^ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org