github-actions[bot] commented on code in PR #32355:
URL: https://github.com/apache/doris/pull/32355#discussion_r1527554650
##########
be/src/olap/rowset/segment_v2/bloom_filter.h:
##########
@@ -55,12 +64,23 @@
static Status create(BloomFilterAlgorithmPB algorithm,
std::unique_ptr<BloomFilter>* bf,
size_t bf_size = 0);
- BloomFilter() : _data(nullptr), _num_bytes(0), _size(0),
_has_null(nullptr) {}
+ BloomFilter() : _data(nullptr), _num_bytes(0), _size(0),
_has_null(nullptr) {
Review Comment:
warning: member initializer for '_has_null' is redundant
[modernize-use-default-member-init]
```suggestion
BloomFilter() : _data(nullptr), _num_bytes(0), _size(0), {
```
##########
be/src/olap/rowset/segment_v2/bloom_filter.h:
##########
@@ -55,12 +64,23 @@
static Status create(BloomFilterAlgorithmPB algorithm,
std::unique_ptr<BloomFilter>* bf,
size_t bf_size = 0);
- BloomFilter() : _data(nullptr), _num_bytes(0), _size(0),
_has_null(nullptr) {}
+ BloomFilter() : _data(nullptr), _num_bytes(0), _size(0),
_has_null(nullptr) {
Review Comment:
warning: member initializer for '_data' is redundant
[modernize-use-default-member-init]
```suggestion
BloomFilter() : , _num_bytes(0), _size(0), _has_null(nullptr) {
```
##########
be/src/olap/rowset/segment_v2/bloom_filter.h:
##########
@@ -17,6 +17,7 @@
#pragma once
+#include <bvar/reducer.h>
Review Comment:
warning: 'bvar/reducer.h' file not found [clang-diagnostic-error]
```cpp
#include <bvar/reducer.h>
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
