HappenLee commented on code in PR #31827:
URL: https://github.com/apache/doris/pull/31827#discussion_r1529671014


##########
be/src/vec/columns/column_nullable.cpp:
##########
@@ -390,17 +391,23 @@ int ColumnNullable::compare_at(size_t n, size_t m, const 
IColumn& rhs_,
     /// instead of the usual nan_direction_hint and is used to implement
     /// the ordering specified by either NULLS FIRST or NULLS LAST in the
     /// ORDER BY construction.
-    const auto& nullable_rhs = assert_cast<const ColumnNullable&>(rhs_);

Review Comment:
   The way change the default behavior in Doris, `compare_at` must use same 
type column



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to