HappenLee commented on code in PR #31827: URL: https://github.com/apache/doris/pull/31827#discussion_r1529669839
########## be/src/exec/tablet_info.cpp: ########## @@ -547,12 +536,13 @@ Status VOlapTablePartitionParam::_create_partition_key(const TExprNode& t_expr, Status VOlapTablePartitionParam::add_partitions( const std::vector<TOlapTablePartition>& partitions) { for (const auto& t_part : partitions) { - auto part = _obj_pool.add(new VOlapTablePartition(&_partition_block)); + auto* part = _obj_pool.add(new VOlapTablePartition(&_partition_block)); part->id = t_part.id; part->is_mutable = t_part.is_mutable; - DCHECK(t_part.__isset.start_keys == t_part.__isset.end_keys && - t_part.__isset.start_keys != t_part.__isset.in_keys); + // we dont pass right keys when it's MAX_VALUE. so may dont have end_keys. + // Review Comment: remove the unless code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org