Lchangliang commented on code in PR #30039: URL: https://github.com/apache/doris/pull/30039#discussion_r1522606273
########## be/src/io/cache/file_cache_storage.h: ########## @@ -0,0 +1,42 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include "io/cache/file_cache_utils.h" +#include "util/slice.h" + +namespace doris::io { + +class BlockFileCacheManager; + +class FileCacheStorage { +public: + FileCacheStorage() = default; + virtual ~FileCacheStorage() = default; + virtual Status init(BlockFileCacheManager* _mgr) = 0; + virtual Status append(const FileCacheKey& key, const Slice& value) = 0; + virtual Status finalize(const FileCacheKey& key) = 0; + virtual Status read(const FileCacheKey& key, size_t value_offset, Slice result) = 0; + virtual Status remove(const FileCacheKey& key) = 0; + virtual Status change_key_meta(const FileCacheKey& key, const KeyMeta& new_meta) = 0; + // use when lazy load cache + virtual void load_blocks_directly_unlocked(BlockFileCacheManager* _mgr, const FileCacheKey& key, Review Comment: The "unlocked" means the lock is not need in this method and it requires a lock on the outside. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
