HappenLee commented on code in PR #31250:
URL: https://github.com/apache/doris/pull/31250#discussion_r1502017167
##########
be/src/runtime/runtime_predicate.h:
##########
@@ -52,25 +53,32 @@ class RuntimePredicate {
void set_tablet_schema(TabletSchemaSPtr tablet_schema) {
std::unique_lock<std::shared_mutex> wlock(_rwlock);
+ if (_tablet_schema) {
+ return;
+ }
_tablet_schema = tablet_schema;
+ int32_t col_unique_id = _tablet_schema->column(_col_name).unique_id();
+ uint32_t index = _tablet_schema->field_index(col_unique_id);
+ _predicate = SharedPredicate::create_shared(index);
}
- std::shared_ptr<ColumnPredicate> get_predictate() {
+ std::shared_ptr<ColumnPredicate> get_predicate() {
std::shared_lock<std::shared_mutex> rlock(_rwlock);
- return _predictate;
+ return _predicate;
}
Status update(const Field& value, const String& col_name, bool is_reverse);
private:
mutable std::shared_mutex _rwlock;
Field _orderby_extrem {Field::Types::Null};
- std::shared_ptr<ColumnPredicate> _predictate;
+ std::shared_ptr<ColumnPredicate> _predicate;
TabletSchemaSPtr _tablet_schema = nullptr;
std::unique_ptr<Arena> _predicate_arena;
Review Comment:
Arena should be member ，not ptr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
