HappenLee commented on code in PR #31250:
URL: https://github.com/apache/doris/pull/31250#discussion_r1501993853
##########
be/src/olap/accept_null_predicate.h:
##########
@@ -149,19 +151,10 @@ class AcceptNullPredicate : public ColumnPredicate {
std::string get_search_str() const override { return
_nested->get_search_str(); }
- std::string debug_string() const override {
- return "passnull predicate for " + _nested->debug_string();
- }
-
- /// Some predicates need to be cloned for each segment.
- bool need_to_clone() const override { return _nested->need_to_clone(); }
-
void clone(ColumnPredicate** to) const override {
Review Comment:
here delete the need to clone code，why not delete `clone` interface also
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
