github-actions[bot] commented on code in PR #29188:
URL: https://github.com/apache/doris/pull/29188#discussion_r1437487486
##########
be/src/runtime/group_commit_mgr.cpp:
##########
@@ -485,33 +485,17 @@ Status LoadBlockQueue::close_wal() {
return Status::OK();
}
-bool LoadBlockQueue::has_enough_wal_disk_space(
- const std::vector<std::shared_ptr<vectorized::Block>>& blocks, const
TUniqueId& load_id,
- bool is_blocks_contain_all_load_data) {
- size_t blocks_size = 0;
- for (auto block : blocks) {
- blocks_size += block->bytes();
- }
- size_t content_length = 0;
- Status st =
ExecEnv::GetInstance()->group_commit_mgr()->get_load_info(load_id,
&content_length);
- if (st.ok()) {
-
RETURN_IF_ERROR(ExecEnv::GetInstance()->group_commit_mgr()->remove_load_info(load_id));
- } else {
- return Status::InternalError("can not find load id.");
- }
- size_t pre_allocated = is_blocks_contain_all_load_data
- ? blocks_size
- : (blocks_size > content_length ?
blocks_size : content_length);
+bool LoadBlockQueue::has_enough_wal_disk_space(size_t pre_allocated) {
Review Comment:
warning: method 'has_enough_wal_disk_space' can be made static
[readability-convert-member-functions-to-static]
be/src/runtime/group_commit_mgr.h:67:
```diff
- bool has_enough_wal_disk_space(size_t pre_allocated);
+ static bool has_enough_wal_disk_space(size_t pre_allocated);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
