mymeiyi commented on code in PR #29188:
URL: https://github.com/apache/doris/pull/29188#discussion_r1437342838
##########
be/src/runtime/group_commit_mgr.cpp:
##########
@@ -487,31 +487,24 @@ Status LoadBlockQueue::close_wal() {
bool LoadBlockQueue::has_enough_wal_disk_space(
const std::vector<std::shared_ptr<vectorized::Block>>& blocks, const
TUniqueId& load_id,
- bool is_blocks_contain_all_load_data) {
+ bool is_blocks_contain_all_load_data, size_t content_length) {
size_t blocks_size = 0;
Review Comment:
It's better to change the function to `bool
LoadBlockQueue::has_enough_wal_disk_space(size_t pre_allocated)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
