github-actions[bot] commented on code in PR #28698:
URL: https://github.com/apache/doris/pull/28698#discussion_r1432356524
##########
be/src/pipeline/exec/exchange_sink_buffer.cpp:
##########
@@ -45,16 +45,40 @@
#include "vec/sink/vdata_stream_sender.h"
namespace doris {
+
namespace vectorized {
+BroadcastPBlockHolder::~BroadcastPBlockHolder() {
+ // lock the parent queue, if the queue could lock success, then return the
block
+ // to the queue, to reuse the block
+ std::shared_ptr<BroadcastPBlockHolderQueue> tmp_queue =
_parent_creator.lock();
+ if (tmp_queue != nullptr) {
+
tmp_queue->push(BroadcastPBlockHolder::create_shared(std::move(_pblock)));
+ }
+ // If the queue already deconstruted, then release pblock automatically
since it
+ // is a unique ptr.
+}
-void BroadcastPBlockHolder::unref() noexcept {
- DCHECK_GT(_ref_count._value, 0);
- auto old_value = _ref_count._value.fetch_sub(1);
- if (_dep && old_value == 1) {
- _dep->return_available_block();
+void BroadcastPBlockHolderQueue::push(std::shared_ptr<BroadcastPBlockHolder>
holder) {
Review Comment:
warning: method 'push' can be made static
[readability-convert-member-functions-to-static]
be/src/pipeline/exec/exchange_sink_buffer.h:107:
```diff
- void push(std::shared_ptr<BroadcastPBlockHolder> holder);
+ static void push(std::shared_ptr<BroadcastPBlockHolder> holder);
```
##########
be/src/pipeline/exec/exchange_sink_buffer.cpp:
##########
@@ -45,16 +45,40 @@
#include "vec/sink/vdata_stream_sender.h"
namespace doris {
+
namespace vectorized {
+BroadcastPBlockHolder::~BroadcastPBlockHolder() {
+ // lock the parent queue, if the queue could lock success, then return the
block
+ // to the queue, to reuse the block
+ std::shared_ptr<BroadcastPBlockHolderQueue> tmp_queue =
_parent_creator.lock();
+ if (tmp_queue != nullptr) {
+
tmp_queue->push(BroadcastPBlockHolder::create_shared(std::move(_pblock)));
+ }
+ // If the queue already deconstruted, then release pblock automatically
since it
+ // is a unique ptr.
+}
-void BroadcastPBlockHolder::unref() noexcept {
- DCHECK_GT(_ref_count._value, 0);
- auto old_value = _ref_count._value.fetch_sub(1);
- if (_dep && old_value == 1) {
- _dep->return_available_block();
+void BroadcastPBlockHolderQueue::push(std::shared_ptr<BroadcastPBlockHolder>
holder) {
+ std::unique_lock(_holders_lock);
+ holder->set_parent_creator(shared_from_this());
+ _holders.push(holder);
+ if (_broadcast_dependency) {
+ _broadcast_dependency->set_ready();
}
}
+std::shared_ptr<BroadcastPBlockHolder> BroadcastPBlockHolderQueue::pop() {
Review Comment:
warning: method 'pop' can be made static
[readability-convert-member-functions-to-static]
be/src/pipeline/exec/exchange_sink_buffer.h:111:
```diff
- std::shared_ptr<BroadcastPBlockHolder> pop();
+ static std::shared_ptr<BroadcastPBlockHolder> pop();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
